Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update hcp-sdk-go and breaking change w/ hvs api #1080

Merged
merged 3 commits into from
Aug 29, 2024
Merged

update hcp-sdk-go and breaking change w/ hvs api #1080

merged 3 commits into from
Aug 29, 2024

Conversation

dhuckins
Copy link
Contributor

🛠️ Description

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@dhuckins dhuckins requested review from a team as code owners August 29, 2024 14:35
pierluc-codes
pierluc-codes approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@pierluc-codes pierluc-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dhuckins dhuckins merged commit 603e57b into main Aug 29, 2024
6 checks passed
@dhuckins dhuckins deleted the dh/update-hvs branch August 29, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierluc-codes pierluc-codes pierluc-codes approved these changes

@maxcoulombe maxcoulombe maxcoulombe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhuckins @pierluc-codes @maxcoulombe