Waypoint: Require TF Project ID to be set, instead of a terraform_cloud_workspace_details resource
#1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
force-pushed
the
waypoint/dont-make-details-resource-required
branch
from
4947ab5 to
de42370
Compare
briancain
commented
Jul 17, 2024
internal/provider/waypoint/resource_waypoint_add_on_definition.go
Outdated
Show resolved
Hide resolved
internal/provider/waypoint/resource_waypoint_add_on_definition.go
Outdated
Show resolved
Hide resolved
internal/provider/waypoint/resource_waypoint_add_on_definition.go
Outdated
Show resolved
Hide resolved
briancain
force-pushed
the
waypoint/dont-make-details-resource-required
branch
from
9fc16ec to
43ae8e3
Compare
briancain
force-pushed
the
waypoint/dont-make-details-resource-required
branch
2 times, most recently
from
f1a6ce9 to
5400bc3
Compare
HenryEstberg
approved these changes
Jul 22, 2024
catsby
approved these changes
Jul 31, 2024
internal/provider/waypoint/resource_waypoint_add_on_definition.go
Outdated
Show resolved
Hide resolved
internal/provider/waypoint/resource_waypoint_add_on_definition.go
Outdated
Show resolved
Hide resolved
briancain
force-pushed
the
waypoint/dont-make-details-resource-required
branch
from
f21e5ca to
0d61988
Compare
paladin-devops
approved these changes
Aug 2, 2024
|
Could someone from @hashicorp/cloud-core-platform-surfaces review this PR? Thanks |
briancain
force-pushed
the
waypoint/dont-make-details-resource-required
branch
from
f6c032c to
8ac2c1e
Compare
|
There are some acceptance test failures but I think those failures are also on |
|
Could one of @meirish @pierluc-codes or @jasonpilz review this? Thanks |
This shouldn't be required, and it's no longer used. This was accidentally left over from a rebase that was from a different PR. Additionally, this puts back some code that was not meant to be deleted.
briancain
force-pushed
the
waypoint/dont-make-details-resource-required
branch
from
ce39700 to
5d3fd1d
Compare
pierluc-codes
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Prior to this commit, the template and add-on definition resource required a user to set a full resource for specifying
terraform_cloud_workspace_details. However, this resource required users to set anamewhich is a value that Waypoint does nothing with. Rather than requiring users to set this field that isn't used in the first place, this pull request instead introduces aterraform_project_idfield that is required, and will use the add-on or template name for the erroneous field.Fixes WAYP-2768 WAYP-2769
🏗️ Acceptance tests
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX' ...