HCPE-921: Upgrade to Go 1.16 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roaks3
approved these changes
Apr 16, 2021
| ## 0.4.1 (April 09, 2021) | ||
|
|
||
| FIXES: | ||
| - resource/consul_cluster: Set "computed=true" option for the vm size (#100) | ||
|
|
||
| ## 0.4.0 (April 07, 2021) | ||
|
|
||
| ⚠️ Note: There is an issue with this version of the HCP Provider in which existing Consul clusters that do not specify size will be recommended by Terraform to be recreated on the next terraform apply, resulting in potential data loss. Please upgrade to the patch v0.4.1 or beyond to avoid this issue. ⚠️ |
README.md
Outdated
| @@ -11,6 +11,7 @@ The HashiCorp Cloud Platform (HCP) Terraform Provider is a plugin for Terraform | |||
| ## Requirements | |||
|
|
|||
| - [Terraform](https://www.terraform.io/downloads.html) >= 0.12.x | |||
| - [Go](https://golang.org/doc/install) >= 1.15 | |||
There was a problem hiding this comment.
Can we move this to the contributing/README.md instead, since users will not need to have Go installed, only developers
1.15 is required to work with tf plugin sdk v2.4.4
since we have internal release process
from release notes
bcmdarroch
force-pushed
the
bump-go-1.16
branch
from
1c48289 to
5c2174e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Go 1.16 provides support for the darwin-arm64 platform, so users on M1 MacBooks can now use the HCP provider. 🎉
This PR also sets the min Go version to 1.15 in compliance with terraform-provider-sdk-v2.4.4.
🏗️ Acceptance tests
Output from acceptance testing: