Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked exactly_one_of for cloudbuild trigger repoSource tag/branch/commit #9952

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Marked exactly_one_of for cloudbuild trigger repoSource tag/branch/commit #9952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/5155.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
cloudbuild: marked `google_cloudbuild_trigger` as requiring one of branch_name/tag_name/commit_sha within build.source.repo_source
```
9 changes: 6 additions & 3 deletions google/resource_cloudbuild_trigger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,11 +529,13 @@ One of 'storageSource' or 'repoSource' must be provided.`,
Description: `Regex matching branches to build. Exactly one a of branch name, tag, or commit SHA must be provided.
The syntax of the regular expressions accepted is the syntax accepted by RE2 and
described at https://github.com/google/re2/wiki/Syntax`,
ExactlyOneOf: []string{},
},
"commit_sha": {
Type: schema.TypeString,
Optional: true,
Description: `Explicit commit SHA to build. Exactly one a of branch name, tag, or commit SHA must be provided.`,
Type: schema.TypeString,
Optional: true,
Description: `Explicit commit SHA to build. Exactly one a of branch name, tag, or commit SHA must be provided.`,
ExactlyOneOf: []string{},
},
"dir": {
Type: schema.TypeString,
Expand Down Expand Up @@ -565,6 +567,7 @@ If omitted, the project ID requesting the build is assumed.`,
Description: `Regex matching tags to build. Exactly one a of branch name, tag, or commit SHA must be provided.
The syntax of the regular expressions accepted is the syntax accepted by RE2 and
described at https://github.com/google/re2/wiki/Syntax`,
ExactlyOneOf: []string{},
},
},
},
Expand Down