Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificate template field to privateca Certificate #9915

Conversation

modular-magician
Copy link
Collaborator

Now that privateca certificate template is present in TF.

Also adds test - which will only successfully run in CI since it depends on a static CA pool.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

(note that tests will have to run on this PR overnight, since the privateca resources are hard to test and depend on a certificate pool that's set up statically).

Fixes #9792.

Release Note Template for Downstream PRs (will be copied)

`privateca`: Added `certificate_template` to `google_privateca_certificate`.

Derived from GoogleCloudPlatform/magic-modules#5135

* Add certificate authority field to Certificate, now that certificate authority is present in TF.

Also adds test - which will only successfully run in CI since it depends on a static CA pool.

* compare resource names instead, because we have a project number.

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 84a5746 into hashicorp:master Aug 25, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2021
@modular-magician modular-magician deleted the downstream-pr-4d07dbcade53b18d6adfa3de1294a8321336abe5 branch November 16, 2024 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support certificateTemplate field in google_privateca_certificate
1 participant