Send billing_project for every request when set #9852
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream of #9636, making up for some churn in headers since then and fixing up some documentation that's become fairly stale
This means that more resources will send the project override header, requiring additional permissions on the quota project. I believe that's fine, and safe- the only way a user could run into issues is if they've enabled
user_project_override
, defined abilling_project
, are using no resources that already supported a billing project (all MMv1 resources, 70%+ of total), and have not granted the appropriate permission to their credentials.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#5086