Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable_on_destroy option to google_project_service. #965

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

nat-henderson
Copy link
Contributor

Closes #5.

@nat-henderson nat-henderson requested a review from rosbo January 16, 2018 19:26
@nat-henderson
Copy link
Contributor Author

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccGoogleProjectService_basic -timeout 120m
=== RUN   TestAccGoogleProjectService_basic                                    
                                                                
--- PASS: TestAccGoogleProjectService_basic (64.95s)                           
PASS                                         
ok      github.com/terraform-providers/terraform-provider-google/google 64.958s

@nat-henderson
Copy link
Contributor Author

CI's broken - I built locally and all is well.
https://www.traviscistatus.com/incidents/c1s4dlyxd4lf

@nat-henderson nat-henderson merged commit ea50226 into hashicorp:master Jan 16, 2018
@nat-henderson nat-henderson deleted the optional-disable branch January 16, 2018 22:39
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Sep 27, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setting to stop google_project_services from being deleted
2 participants