Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize resource name extraction from self_link/uri #939

Merged
merged 4 commits into from
Jan 17, 2018
Merged

Standardize resource name extraction from self_link/uri #939

merged 4 commits into from
Jan 17, 2018

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Jan 9, 2018

Doing it manually is error prone and adds extra code.
Having two methods doing the same thing is bad.

Better standardize.

@rosbo rosbo force-pushed the name-from-self-link branch from 1cc23ed to 9b8a852 Compare January 10, 2018 23:46
@rosbo rosbo requested a review from danawillow January 10, 2018 23:48
@rosbo rosbo requested review from nat-henderson and removed request for danawillow January 17, 2018 18:30
@rosbo rosbo assigned nat-henderson and unassigned danawillow Jan 17, 2018
nat-henderson
nat-henderson approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a big style improvement.

Can you show me where the linkDiffSuppress tests are? I see that the behavior hasn't changed, so go ahead and submit, but I'm not sure how that gets called or tested exactly.

@rosbo rosbo merged commit d0f5fec into hashicorp:master Jan 17, 2018
@rosbo rosbo deleted the name-from-self-link branch January 17, 2018 18:45
@rosbo
Copy link
Contributor Author

rosbo commented Jan 17, 2018

linkDiffSupress is added as a DiffSuppressFunc for some fields in resource schemas. There is no unit test for it (I will open a new PR to fix this) but this is tested indirectly through the acceptance tests.

modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Sep 27, 2019
@modular-magician @rileykarson
Namespace service accounts created in tests (hashicorp#939)
df3582c 
Signed-off-by: Modular Magician <[email protected]>
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nat-henderson nat-henderson nat-henderson approved these changes

Assignees

@nat-henderson nat-henderson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosbo @nat-henderson @danawillow