Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote customResponseHeaders to GA #9366

Closed
wants to merge 1 commit into from
Closed

Promote customResponseHeaders to GA #9366

wants to merge 1 commit into from

Conversation

glerchundi
Copy link

@glerchundi glerchundi commented Jun 14, 2021 •
edited
Loading

This change promotes custom_response_headers for
google_compute_backend_service and google_compute_backend_bucket
to GA.

Closes #9360

Signed-off-by: Gorka Lerchundi Osa [email protected]

@glerchundi
Promote customResponseHeaders to GA
37dc3b9 
This change promotes `custom_response_headers` for
`google_compute_backend_service` and `google_compute_backend_bucket`
to GA.

Closes hashicorp#9360

Signed-off-by: Gorka Lerchundi Osa <[email protected]>
@glerchundi glerchundi force-pushed the feature-add-custom-response-headers branch from bd8388b to 37dc3b9 Compare June 14, 2021 20:22
@glerchundi glerchundi changed the title Promote customResponseHeaders to GA (#9360) Promote customResponseHeaders to GA Jun 14, 2021
@c2thorn
Copy link
Collaborator

c2thorn commented Jun 14, 2021

Hi @glerchundi
This repository is managed by the Magic Modules repository, so we cannot make the changes here. I would recommend following the contributing steps in Magic Modules.

At first glance, it seems that a straightforward removal of the beta restrictions introduced in https://github.com/GoogleCloudPlatform/magic-modules/pull/4286/files are all that are needed. I would recommend setting up Magic Modules, making the change, building the GA provider with those changes, and then testing TestAccComputeBackendService_withCustomHeaders in the GA provider to ensure it works correctly.

@glerchundi
Copy link
Author

Ouch, great!

@glerchundi glerchundi closed this Jun 15, 2021
@glerchundi
Copy link
Author

xref GoogleCloudPlatform/magic-modules#4872

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promote google_compute_backend_service.customResponseHeaders to GA
2 participants
@glerchundi @c2thorn