Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute: add support for instance reservation_affinity #9256

Conversation

modular-magician
Copy link
Collaborator

reservation_affinity controls how instances or instances created from
templates consume Compute Engine resource reservations.

Fixes #4593

This hoists my PR from #7669 up to magic-modules so this effort is not on someone else to do.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests. – I ran the subset of tests relating to added functionality
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests). - tests added
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know). - ran the specific subset of tests added for this functionality
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `reservation_affinity` to `google_compute_instance` and `google_compute_instance_template`

Derived from GoogleCloudPlatform/magic-modules#4335

@ghost ghost added size/xl labels May 27, 2021
@modular-magician modular-magician merged commit 3ebd09f into hashicorp:master May 27, 2021
@mmllc-jsilverman
Copy link

Is this what causes my TF plan to want to delete all resources and rebuild them? I can't tel if this code made it into gcp provider > 3.66.1

@balonik
Copy link

balonik commented Jun 8, 2021

@mmllc-jsilverman I can use it with google provider 3.71.0

@mmllc-jsilverman
Copy link

@mmllc-jsilverman I can use it with google provider 3.71.0

I am almost certain that this change is what is causing my problem; the TF cloud run worked when I pinned the provider to the one I am using locally.

I'll just add the reservation_affinity value to my terraform manifests and see if that fixes this for me.

@github-actions
Copy link

github-actions bot commented Jul 9, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2021
@modular-magician modular-magician deleted the downstream-pr-b29aff736b5e8ab5c59ccba59ac1dda1fc139cf3 branch November 17, 2024 00:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reservationAffinity to google_compute_instance
3 participants