Make zone field consistent and truly optional for all resources #914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#816 enabled the
zone
field to be specified at the provider level.However, a few resources such as
google_compute_disk
are setting the zone field in the read method. This was causing a perpetual diff if the zone was inferred from the provider default zone:This fix marks all the
zone
field asComputed
and is consistent about always setting the zone field in the state inside the read method.cc/ @ndmckinley