Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation on Cloud Functions available_memory_mb #8946

Conversation

modular-magician
Copy link
Collaborator

I saw a question about whether we support 8GB (8192) of memory or not because it was introduced in the API, and we don't- these values have changed out of band a few times, and I don't feel that this validation is helpful enough to be worth keeping up with value churn. Also note that our docs never reflected supporting 4GB- I figure it's clear enough what the pattern for 2048/4096/8192 will be, so I just changed values past 1024 to "etc".

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudfunctions: removed bounds on the supported memory range in `google_cloudfunctions_function.available_memory_mb`

Derived from GoogleCloudPlatform/magic-modules#4702

@ghost ghost added size/xs labels Apr 19, 2021
@modular-magician modular-magician merged commit 32226c9 into hashicorp:master Apr 19, 2021
@ghost
Copy link

ghost commented May 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2021
@modular-magician modular-magician deleted the downstream-pr-2e59a359f415ea8d36f83abe20edc77b0a28e19f branch November 16, 2024 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant