-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add temp_bucket
parameter for resource google_dataproc_cluster (fixes #7927)
#8131
Conversation
temp_bucket
parameter for resource google_dataproc_cluster (#7927)temp_bucket
parameter for resource google_dataproc_cluster (fixes #7927)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - seems pretty straightforward! I'll get started on upstreaming this.
e8bc7cc
to
b7ca19d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this ended up breaking all the DataprocCluster tests that don't define an explicit temp bucket, since the server then assigns one for you. (For example, TestAccDataprocCluster_singleNodeCluster.)
The fix for this should be to mark the field as Computed as well as optional. That should still allow setting an explicit value while also accepting whatever the server sends back if there's not a value defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests are passing
I noticed the comment in |
@bartcode thanks for checking back in. I lost track of this, sorry. Let me ping Sam. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so there's just one thing to change - since this is a handwritten resource, the docs also need to be updated manually. They're in website/docs/r/. Thanks!
Thanks! I wasn't aware of those docs, but they should be in order now! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Allow using
temp_bucket
when creating a Dataproc cluster as addressed in #7927 .Closes #7927 .
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)