Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iam workload identity federation #7580

Conversation

modular-magician
Copy link
Collaborator

This is my attempt to add the new Google Workload Identity Federation resources.

fixes #7455

But I run into the issue that the IAM resources seem to be handwritten. Now that I add products/iam/terraform.yaml all the resources in that file get generated to terraform, including things like service_account and role.
What would be the best way to leave the handwritten iam resources alone, but still be able to add the new iam-beta resources for workload identity federation?

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
`google_iam_workload_identity_pool`

Derived from GoogleCloudPlatform/magic-modules#4071

@ghost ghost added size/l labels Oct 20, 2020
@modular-magician modular-magician merged commit b9a44bd into hashicorp:master Oct 20, 2020
@ghost
Copy link

ghost commented Nov 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2020
@modular-magician modular-magician deleted the downstream-pr-18cff41a266a704f883f41d865b944a40edb46fd branch November 16, 2024 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: IAM Workload Identity Federation resources
1 participant