Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating single_cluster_routing in google_bigtable_app_profile #7266

Conversation

modular-magician
Copy link
Collaborator

Fixes b/168053560 (updating certain bt app profile fields failed)

Terraform believed the subfields of single_cluster_routing were updatable and they should have been, but in practice Magic Modules didn't generate the write update handlers.

I don't believe updating to/from single_cluster_routing and multi_cluster_routing is possible, so this schema is a little misleading. However I believe it's an acceptable tradeoff:

  • Since this and mcr are ExactlyOneOf, mcr's ForceNew will still trigger if the user changes which field is set
  • MM doesn't support updating fields that are updatable while their parent field isn't
  • MM doesn't support update masks for non-top-level fields (but specifying the top level field will update all of it's children)

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigtable: fixed the update behaviour of the `single_cluster_routing` sub-fields in `google_bigtable_app_profile`

Derived from GoogleCloudPlatform/magic-modules#3967

@ghost
Copy link

ghost commented Oct 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2020
@modular-magician modular-magician deleted the downstream-pr-eaab447b4e990e609add21a78bff78575f4eb1d2 branch November 17, 2024 01:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant