Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use {product}.googleapis.com endpoints #7045

Conversation

modular-magician
Copy link
Collaborator

Fixes #6783. Holding off on submitting until I find out whether we need to update deployment manager as well, since that's the only one that'll still be using the old syntax for endpoints after this.

Release Note Template for Downstream PRs (will be copied)

all: updated base urls for compute, dns, storage, and bigquery APIs to their recommended endpoints

Derived from GoogleCloudPlatform/magic-modules#3755

* use {product}.googleapis.com endpoints

* use actual correct urls

* fix zone data source test

* fix network peering tests

* possibly fix deleting default network

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added size/xl labels Aug 17, 2020
@modular-magician modular-magician merged commit a82394b into hashicorp:master Aug 17, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 17, 2020
@modular-magician modular-magician deleted the downstream-pr-c28e684ed4939f2de34cb4118ff5e635716e7293 branch November 17, 2024 01:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
1 participant