Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BigQuery hourly time partitioning #6675

Merged
merged 6 commits into from
Jun 25, 2020
Merged

Add support for BigQuery hourly time partitioning #6675

merged 6 commits into from
Jun 25, 2020

Conversation

fpopic
Copy link
Contributor

@fpopic fpopic commented Jun 24, 2020

Fixes #6676.

Check googleapis/google-cloud-go@8618bf3 functionality.

My commits here were not the nicest (totally Go noob), guess it will be just squashed?

So in the end

  • update validations and description for HOUR time partitioning
  • add one unit test for creating a table using HOUR time partitioning

@ghost ghost added the size/xs label Jun 24, 2020
@ghost ghost requested a review from emilymye June 24, 2020 06:58
@fpopic fpopic marked this pull request as ready for review June 24, 2020 08:16
fpopic added 2 commits June 24, 2020 12:15
…com:fpopic/terraform-provider-google into add_support_for_bq_hourly_time_partitioning
@emilymye emilymye merged commit 29f5cbc into hashicorp:master Jun 25, 2020
@fpopic fpopic deleted the add_support_for_bq_hourly_time_partitioning branch June 25, 2020 20:30
@ghost
Copy link

ghost commented Jul 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for BigQuery hourly time partitioning
2 participants