Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetching of app_engine_standard_app_version data #6435

Conversation

modular-magician
Copy link
Collaborator

Release Note Template for Downstream PRs (will be copied)

appengine: added ability to fully sync `StandardAppVersion` resources

@megan07 I've tried to match the generated terraform output to my original PR #6388

I didn't try to add your suggested

      handlers: !ruby/object:Overrides::Terraform::PropertyOverride
        default_from_api: true

since I don't have any appengine versions with just the default handlers to try with.
Also I don't currently have FlexibleAppVersion resources setup in terraform to play around with.

Maybe this PR can serve as base for more changes.

References

Derived from GoogleCloudPlatform/magic-modules#3536

@ghost ghost added the size/xs label May 20, 2020
@modular-magician modular-magician merged commit 75273fa into hashicorp:master May 20, 2020
@ghost
Copy link

ghost commented Jun 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 20, 2020
@modular-magician modular-magician deleted the downstream-pr-358e3b8be47a9a35760350f4337aac4fb3129fe8 branch November 17, 2024 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant