Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tags argument specifics network tags to attach to the instance #6398

Closed
wants to merge 1 commit into from

Conversation

dmyerscough
Copy link
Contributor

The tags argument specifies network tags that are to be attached to the instance.

@ghost ghost added the size/xs label May 17, 2020
@ghost ghost requested a review from nat-henderson May 17, 2020 02:07
@ghost ghost added the documentation label May 17, 2020
@nat-henderson
Copy link
Contributor

Hmm, thanks for the proposal, but I'm not sure that that's clearer - how would you distinguish a network tag from any other kind of tag?

@dmyerscough
Copy link
Contributor Author

When using the AWS module, they use tags for tagging instances.

tags          = {
    Name        = "Application Server"
    Environment = "production"
  }

However, in GCP the equivalent is metadata. I thought it would've been a little more clear since GCP "tags" in this scenario refer to network tags.

@nat-henderson
Copy link
Contributor

Got it - I agree, the docs do use the terms "network tags" and "tags" interchangeably, and that does sound clearer to an AWS user. Thanks!

The docs I'm referring to are https://cloud.google.com/vpc/docs/add-remove-network-tags. :)

Would you mind proposing this change to this file instead? This code is automatically generated from that code, so a change only here would be clobbered.

@dmyerscough
Copy link
Contributor Author

Thank you @ndarilek, PR opened: GoogleCloudPlatform/magic-modules#3557

@ghost
Copy link

ghost commented Jun 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants