Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming datasources files and links inside erb. #6142

Closed
wants to merge 1 commit into from

Conversation

jayolmos
Copy link

Hello :)

this PR is related the documentation structure issue in #2876 .

I was reviewing the document structure in aws and azure and for standard I think Riley is right to go for no prefix inside datasources structure. So this PR moves the files and change the links inside the google.erb file.

Inside the google.erb in master and also this PR, there's two missing links:

  • compute_resource_policy
  • secret_manager_secret_version

I don't know if this is ok with the contributing guide so please let me know if I can help in anything related to this issue.

Thanks!

@ghost ghost requested review from slevenick April 17, 2020 19:59
@slevenick
Copy link
Collaborator

Hey @jayolmos this PR is marked as draft, is that intentional, or is it ready for review?

@jayolmos
Copy link
Author

Hello @slevenick as the issue was not fully defined I wasn't sure if open as draft or as ready for review. So if it looks good I can move it to review and take a look to the failed links.

@slevenick
Copy link
Collaborator

Yeah, I think it would be good to do this. One thing to note is that some work around generating the google.erb file was done recently, so you may notice merge issues now. See: #6001

Also, if you are able it would be preferable to make this PR against https://github.com/GoogleCloudPlatform/magic-modules which is the tool that generates these files. Normally I could upstream a PR against this repo to that one, but given that most of the changes are renames to files it could get tricky.

@jayolmos
Copy link
Author

Thanks! Closing this PR and working in the new one.

@jayolmos jayolmos closed this Apr 25, 2020
@jayolmos jayolmos deleted the feature/renaming-docs branch April 25, 2020 19:21
@ghost
Copy link

ghost commented May 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants