-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand docs for auto_healing_policies for Instance Group Managers #612
Conversation
8e652b0
to
1ec22c2
Compare
1ec22c2
to
0805197
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, and is a nice addition, I think. Only request, and it's a bit nitpicky--can you just run the example HCL through terraform fmt
? We try to make the HCL in our docs properly fmt'd whenever possible.
Thanks for the PR!
Adds more information for both (Zonal) Instance Group Managers and Regional Instance Group Managers.
0805197
to
25bad09
Compare
Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Expand docs for auto_healing_policies for Instance Group Managers
Vendor the latest Terraform so we can get the fix for ImportStateVerify diffing on Removed fields.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This should make it clearer what is required for setting up
auto_healing_policies
, especially that thehealth_check
URL is a link to a resource, not to the health check URL directly.