Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand docs for auto_healing_policies for Instance Group Managers #612

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

danielcompton
Copy link
Contributor

This should make it clearer what is required for setting up auto_healing_policies, especially that the health_check URL is a link to a resource, not to the health check URL directly.

@danielcompton danielcompton force-pushed the patch-1 branch 2 times, most recently from 8e652b0 to 1ec22c2 Compare October 21, 2017 08:59
@danielcompton danielcompton changed the title Expand docs for auto_healing_policies in compute_instance_group_manager Expand docs for auto_healing_policies for Instance Group Managers Oct 21, 2017
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and is a nice addition, I think. Only request, and it's a bit nitpicky--can you just run the example HCL through terraform fmt? We try to make the HCL in our docs properly fmt'd whenever possible.

Thanks for the PR!

Adds more information for both (Zonal) Instance Group Managers and
Regional Instance Group Managers.
@danielcompton
Copy link
Contributor Author

Fixed!

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paddycarver paddycarver merged commit 548d572 into hashicorp:master Oct 26, 2017
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
Expand docs for auto_healing_policies for Instance Group Managers
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
Vendor the latest Terraform so we can get the fix for ImportStateVerify
diffing on Removed fields.
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants