Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not diffSuppress port when port_specification is not "USED_FIXED_PORT" #5997

Conversation

modular-magician
Copy link
Collaborator

Fixes #5905

Release Note Template for Downstream PRs (will be copied)

compute: Fixed an issue where `port` could not be removed from health checks

Derived from GoogleCloudPlatform/magic-modules#3316

…hicorp#3316)

* Do not diffSuppress `port` when `port_specification` is "USED_NAME_PORT"

* Formatting

* Update health_check.erb

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/xs label Mar 27, 2020
@modular-magician modular-magician merged commit 6b1d4f9 into hashicorp:master Mar 27, 2020
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
@modular-magician modular-magician deleted the downstream-pr-1f033595d3d6da9ecfc59ef5267b94c6084c4b84 branch November 17, 2024 02:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to switch from port to port_name in tcp health check
1 participant