Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing quotes to example for saving GCP SA key as k8s secret #5983

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Conversation

muru
Copy link
Contributor

@muru muru commented Mar 26, 2020

Without the quotes, terraform complains about missing quotes.

@ghost ghost added the size/xs label Mar 26, 2020
@ghost ghost requested a review from danawillow March 26, 2020 06:54
@ghost ghost added the documentation label Mar 26, 2020
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @muru!

@muru
Copy link
Contributor Author

muru commented Mar 27, 2020

Oh, sorry, I just skimmed through the contribution guide and didn't realize that the auto-generated part applies to most of the repo. I noticed the missing CLA warning in the upstream PR, and have now signed it, things should be fine. Should this PR just be closed if it actually gets upstreamed?

@danawillow
Copy link
Contributor

I can merge both- what you did is totally fine. That specific file isn't autogenerated, so I was able to easily run a script to patch your change into the MM repo. For more complicated changes though, it's better to do in MM directly since the script can be finicky.

@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants