Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add desired_status argument to google_compute_instance #5734

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Feb 21, 2020

Upstreams #4797

#4797 (comment) is probably a helpful reference for behaviour. Tests have been changed a little since they made the table, but they roughly match.

I applied some docs changes during the (manual) upstreaming, since the script didn't like doing that many commits. They'll get applied by the Magician during the sync.

Release Note Template for Downstream PRs (will be copied)

compute: added the ability to manage the status of `google_compute_instance` resources with the `desired_status` field

Derived from GoogleCloudPlatform/magic-modules#3154

* Add desired_status argument to google_compute_instance

* Fix network naming to match MM@HEAD

Co-authored-by: norbjd <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 87dbb50 into hashicorp:master Feb 21, 2020
@ghost
Copy link

ghost commented Mar 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 23, 2020
@modular-magician modular-magician deleted the downstream-pr-bd3a6b7cbf2a2fec83cc71010745982fa0fd1b60 branch November 17, 2024 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant