Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features: add data_source_google_compute_backend_bucket #5700

Merged
merged 1 commit into from
Feb 19, 2020
Merged

features: add data_source_google_compute_backend_bucket #5700

merged 1 commit into from
Feb 19, 2020

Conversation

bdronneau
Copy link
Contributor

@bdronneau bdronneau commented Feb 18, 2020

Hi,

I try to fix my issue with this PR.
I made a backport in #5699

Testing

 make testacc TEST=./google TESTARGS='-run=TestAccDataSourceComputeBackendBucket_basic'
==> Checking source code against gofmt...                                                                                               
==> Checking that code complies with gofmt requirements...                                                                              
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccDataSourceComputeBackendBucket_basic -timeout 240m -ldflags="-X=github.com/terraform-providers/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceComputeBackendBucket_basic                                                                                   
=== PAUSE TestAccDataSourceComputeBackendBucket_basic                                                                                   
=== CONT  TestAccDataSourceComputeBackendBucket_basic                                                                                   
--- PASS: TestAccDataSourceComputeBackendBucket_basic (23.22s)                                                                          
PASS                                                                                                                                    
ok      github.com/terraform-providers/terraform-provider-google/google 23.261s 
Release note added with upstreaming PR

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing! I'll upstream to Magic Modules & merge this PR.

@ghost
Copy link

ghost commented Mar 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants