Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch new cloud run API defaults. #5600

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Catch new cloud run API defaults. #5600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions google/resource_cloud_run_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,16 @@ responsible for materializing the container image from source.`,
Schema: map[string]*schema.Schema{
"spec": {
Type: schema.TypeList,
Required: true,
Computed: true,
Optional: true,
Description: `RevisionSpec holds the desired state of the Revision (from the client).`,
MaxItems: 1,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"containers": {
Type: schema.TypeList,
Required: true,
Computed: true,
Optional: true,
Description: `Container defines the unit of execution for this Revision.
In the context of a Revision, we disallow a number of the fields of
this Container, including: name, ports, and volumeMounts.
Expand Down Expand Up @@ -240,6 +242,7 @@ https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names`,
},
"resources": {
Type: schema.TypeList,
Computed: true,
Optional: true,
Description: `Compute Resources required by this container. Used to set values such as max memory
More info:
Expand All @@ -249,6 +252,7 @@ https://kubernetes.io/docs/concepts/storage/persistent-volumes#resources`,
Schema: map[string]*schema.Schema{
"limits": {
Type: schema.TypeMap,
Computed: true,
Optional: true,
Description: `Limits describes the maximum amount of compute resources allowed.
The values of the map is string form of the 'quantity' k8s type:
Expand Down Expand Up @@ -282,6 +286,7 @@ might be configured in the container image.`,
},
"container_concurrency": {
Type: schema.TypeInt,
Computed: true,
Optional: true,
Description: `ContainerConcurrency specifies the maximum allowed in-flight (concurrent)
requests per container of the Revision. Values are:
Expand Down Expand Up @@ -312,6 +317,7 @@ that the system will manipulate this based on routability and load.`,
},
"metadata": {
Type: schema.TypeList,
Computed: true,
Optional: true,
Description: `Optional metadata for this Revision, including labels and annotations.
Name will be generated by the Configuration. To set minimum instances
Expand All @@ -325,6 +331,7 @@ annotation key.`,
Schema: map[string]*schema.Schema{
"annotations": {
Type: schema.TypeMap,
Computed: true,
Optional: true,
Description: `Annotations is a key value map stored with a resource that
may be set by external tools to store and retrieve arbitrary metadata. More
Expand Down