Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated expiration_time in tests to use year < 2038, undeprecated it #5531

Conversation

modular-magician
Copy link
Collaborator

When changing the code to upgrade to support second-generation-only instances, the authorized_networks tests failed to create instances because of the expiration_time. I assumed it had to do with the upgrade, so I deprecated the field, however, we later found out it is a limitation on the value of the year, so now I have updated the tests to use a year < 2038, and they pass on second generation instances.

Release Note Template for Downstream PRs (will be copied)

sql: undeprecated `settings.ip_configuration.authorized_networks.expiration_time`

Derived from GoogleCloudPlatform/magic-modules#3034

@modular-magician modular-magician merged commit a4a451f into hashicorp:master Jan 29, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
@modular-magician modular-magician deleted the downstream-pr-3460a6e6b99f08488b3666e797c6b501e9db890a branch November 17, 2024 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant