Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set master_authorized_networks_config.enabled=true ... #5343

Conversation

modular-magician
Copy link
Collaborator

…when there is a master_authorized_networks_config block in terraform-google-conversion. This aligns with how terraform-google-provider handles master_authorized_networks_config block. https://github.com/GoogleCloudPlatform/magic-modules/blob/435551bdd45b3d70d145125edae1c6a0dac3517b/third_party/terraform/resources/resource_container_cluster.go.erb#L2400-L2407

Release Note Template for Downstream PRs (will be copied)

terraform-google-conversion only: set master_authorized_networks_config.enabled to true when there is a master_authorized_networks_config block in Terraform configuration.

Derived from GoogleCloudPlatform/magic-modules#2939

jsoref and others added 15 commits January 2, 2020 17:06
* Updated google_folder.html

The page in the first example shows that you should use organization_id with value of 1234567. In the Import example, it's not clear whether organization_id is user, or folder_id is used. API call behind this import command is only accepting folder_id (can be checked when setting TF_LOG to trace and viewing the API call)

* Update website/docs/r/google_folder.html.markdown

Co-Authored-By: Dana Hoffman <[email protected]>

Co-authored-by: Dana Hoffman <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Riley Karson <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Brian Hildebrandt <[email protected]>
@modular-magician modular-magician merged commit c3b741d into hashicorp:downstream-master Jan 8, 2020
@ghost
Copy link

ghost commented Feb 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 8, 2020
@modular-magician modular-magician deleted the downstream-pr-988be6ed6221958bfc511623ad33eb8935ca1c08 branch November 17, 2024 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants