Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test domain for Cloud Run Domain Mapping #5279

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Fix test domain for Cloud Run Domain Mapping #5279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/resource_app_engine_domain_mapping_generated_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func TestAccAppEngineDomainMapping_appEngineDomainMappingBasicExample(t *testing
func testAccAppEngineDomainMapping_appEngineDomainMappingBasicExample(context map[string]interface{}) string {
return Nprintf(`
resource "google_app_engine_domain_mapping" "domain_mapping" {
domain_name = "dm-test-%{random_suffix}.gcp.tfacc.hashicorptest.com"
domain_name = "tf-test-domain%{random_suffix}.gcp.tfacc.hashicorptest.com"

ssl_settings {
ssl_management_type = "AUTOMATIC"
Expand Down
7 changes: 3 additions & 4 deletions google/resource_cloud_run_domain_mapping_generated_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ func TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample(t *testing.T
t.Parallel()

context := map[string]interface{}{
"namespace": getTestProjectFromEnv(),
"verified_domain": "tftest-domainmapping.com",
"random_suffix": acctest.RandString(10),
"namespace": getTestProjectFromEnv(),
"random_suffix": acctest.RandString(10),
}

resource.Test(t, resource.TestCase{
Expand Down Expand Up @@ -73,7 +72,7 @@ resource "google_cloud_run_service" "default" {

resource "google_cloud_run_domain_mapping" "default" {
location = "us-central1"
name = "%{verified_domain}"
name = "tf-test-domain%{random_suffix}.gcp.tfacc.hashicorptest.com"

metadata {
namespace = "%{namespace}"
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/app_engine_domain_mapping.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ To get more information about DomainMapping, see:

```hcl
resource "google_app_engine_domain_mapping" "domain_mapping" {
domain_name = "dm-test-.gcp.tfacc.hashicorptest.com"
domain_name = "verified-domain.com"

ssl_settings {
ssl_management_type = "AUTOMATIC"
Expand Down