update formatting

[pradeepbhadani]

Adding changes from https://github.com/terraform-providers/terraform-provider-google/pull/5097/files

[pradeepbhadani]

@paddycarver This is the new PR replacing #5097

[pradeepbhadani]

@danawillow

[danawillow]

hashicorp gets the full two weeks of christmas / new years off, so paddy won't be back until next week. I'm happy to take care of it this time, but I'd prefer that tagging me into PRs doesn't become a habit :)

[danawillow]

Looks like the main change in this is to an autogenerated resource (you can tell by the comment at the top of the file). The way we add examples for these is pretty different than just editing the file, so it'll be a lot easier for us if you could make the PR against magic modules itself. GoogleCloudPlatform/magic-modules#2869 is a recent PR that added a new example, so you can base yours off of that.

For handwritten resources and docs, we're still happy to accept PRs in TPG and then we can run a script to upstream them that'll preserve you as the author of the commit, but since the MM change is significantly different for generated resources, the authorship story gets fuzzier and it's easier to just open those there.

[pradeepbhadani]

Hi @danawillow , I thought paddy might be busy so tagged you as you are very active on this repo.

@paddycarver suggested removing one commit so I raise this new PR after removing problematic commit. I will wait for @paddycarver to have a look at this PR and comment.

Is there an easy way to identify the files that are managed by the Magic module or hand-written?

[danawillow]

Yeah, I'll let him decide if he wants to try upstreaming it once he's back next week.

You can tell if a file is autogenerated by checking if it has a comment at the top that says

***     AUTO GENERATED CODE    ***    AUTO GENERATED CODE     ***

Even if a file is written by hand, you can still modify it in the magic modules repo if you'd like- those live at https://github.com/GoogleCloudPlatform/magic-modules/tree/master/third_party/terraform. We have some documentation around this in the CONTRIBUTING guide. Hope that helps!

[danawillow]

@pradeepbhadani, I'm sorry again about the delay. This currently looks like it has some merge conflict markers as well as some changes that I believe you did already propose against MM. If there's anything else outstanding re: this PR, please feel free to open a new one!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!