Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc related to use_ip_aliases in google_container_cluster #5112

Conversation

SezBulent
Copy link

@SezBulent SezBulent commented Dec 9, 2019

Hello,
I noticed that the details were not consistent, and for the same resource block the information was different. I've updated the docs to have the same info for the related block.

@ghost ghost added the size/xs label Dec 9, 2019
@ghost ghost requested a review from chrisst December 9, 2019 16:15
@ghost ghost added the documentation label Dec 9, 2019
@rileykarson
Copy link
Collaborator

Sorry we didn't get to this, @SezBulent. We'd had some crossed wires, where two developers had touched the resource at the same time and made conflicting changes. We shipped the right change (removing the field) but these docs got left behind.

They've since been updated. As a result, I'm going to close this out.

@rileykarson rileykarson closed this Feb 7, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants