Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation on Access Level #5053

Closed
wants to merge 1 commit into from

Conversation

bcadiot
Copy link
Contributor

@bcadiot bcadiot commented Dec 3, 2019

This PR fixe a little mistake on the documentation.

Access Level members can not be Groups as expressed in the API.

A feature request is open in the Google public bug tracker : https://issuetracker.google.com/issues/119203606

Feel free to change the formulation if needed (the important fact is that you can't use groups as members for this resource).

@ghost ghost added the size/xs label Dec 3, 2019
@ghost ghost requested review from slevenick December 3, 2019 13:30
@ghost ghost added the documentation label Dec 3, 2019
@slevenick
Copy link
Collaborator

Thanks for the fix! I'll upstream this to our code generator so it gets preserved!

@slevenick
Copy link
Collaborator

This resource is generated via a code generation tool, so the docs need to be changed in a separate file. This PR should fix this in a similar way: GoogleCloudPlatform/magic-modules#2772

@slevenick
Copy link
Collaborator

Closing in favor of the generated PRs that also change the description in the terraform resource schema

@slevenick slevenick closed this Dec 3, 2019
@bcadiot
Copy link
Contributor Author

bcadiot commented Dec 4, 2019

Closing in favor of the generated PRs that also change the description in the terraform resource schema

Thanks a lot @slevenick !
I didn't realized that the code is generated through a module. I will create my PR directly in it the next time

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants