Add support for cloud run service IAM. Use base paths via replaceVars #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modular-magician
force-pushed
the
codegen-pr-2770
branch
from
2ab960a to
c9aa18d
Compare
modular-magician
force-pushed
the
codegen-pr-2770
branch
from
c9aa18d to
c98d3e1
Compare
Signed-off-by: Modular Magician <[email protected]>
modular-magician
force-pushed
the
codegen-pr-2770
branch
from
c98d3e1 to
e58ed5f
Compare
chrisst
reviewed
Dec 5, 2019
|
|
||
| IAM binding imports use space-delimited identifiers: the resource in question and the role, e.g. | ||
| ``` | ||
| $ terraform import google_cloud_run_service_iam_binding.editor "locations/{{location}}/namespaces/{{project}}/services/{{service}} roles/viewer" |
There was a problem hiding this comment.
@slevenick I think the import id's here are wrong
There was a problem hiding this comment.
Oh no I just merged this. I'll fix ASAP
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Author: @slevenick