Correct default GCP env var for credential path in Guide

[draconteus]

No description provided.

[pradeepbhadani]

Could you please replace GOOGLE_CLOUD_KEYFILE_JSON with GOOGLE_APPLICATION_CREDENTIALS on this line as well?

[draconteus]

Oh, yeah sure.

[megan07]

Sorry, I think I got ahead of myself here. I'm not sure this needs to be changed. To clarify how to set credentials you can read more here https://www.terraform.io/docs/providers/google/guides/provider_reference.html#credentials-1. GOOGLE_CLOUD_KEYFILE_JSON is one of the environment variables to use for the recommended Terraform-specific service accounts. GOOGLE_APPLICATION_CREDENTIALS is used as a fallback if a Terraform-specific service account key file is not provided. These credentials are your Google app default credentials.

[pradeepbhadani]

@megan07 - Agree, but most of the places GOOGLE_APPLICATION_CREDENTIALS is being used. Maybe good to have this PR merged to make documentation consistent?

[megan07]

Hi @pradeepbhadani, thank you for pointing that out! I think the consistency that we want to keep would be with the recommended practice. If GOOGLE_APPLICATION_CREDENTIALS is used elsewhere in the documentation, I think it would be great to change those cases to GOOGLE_CLOUD_KEYFILE_JSON instead.

[draconteus]

Sorry, I think I got ahead of myself here. I'm not sure this needs to be changed. To clarify how to set credentials you can read more here https://www.terraform.io/docs/providers/google/guides/provider_reference.html#credentials-1. GOOGLE_CLOUD_KEYFILE_JSON is one of the environment variables to use for the recommended Terraform-specific service accounts. GOOGLE_APPLICATION_CREDENTIALS is used as a fallback if a Terraform-specific service account key file is not provided. These credentials are your Google app default credentials.

The problem was for me, that I tried to use GOOGLE_CLOUD_KEYFILE_JSON as it was stated in the docs, but does not worked and I get credentials cannot be found error.
I haven't tried the other two env var mentioned in the docs (I'll try it later), unfortunately I missed the mentioned documentation and found the GOOGLE_APPLICATION_CREDENTIALS in Google Cloud docs.

Update:
I just tested the above mentioned env vars:
GOOGLE_CREDENTIALS=./creds.json terraform plan - works fine
GOOGLE_CLOUD_KEYFILE_JSON=./creds.json terraform plan - ends with could not find default credentials error
GCLOUD_KEYFILE_JSON=./creds.json terraform plan - ends with could not find default credentials error

[megan07]

Hi @draconteus ! Sorry about this, I accidentally merged this instead of another PR I was looking at (too many tabs open). I will have to test this further, as I have GOOGLE_CLOUD_KEYFILE_JSON set in my environment variables and have never seen that error. I will look at this ASAP and let you know what I think the reasoning might be behind your issue. Meanwhile, could you please open a new PR (or issue) so we can track it there?
Sorry again, I appreciate your patience. Thank you!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!