Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update compute_attached_disk.html.markdown #5003

Merged
merged 2 commits into from
Dec 4, 2019
Merged

update compute_attached_disk.html.markdown #5003

merged 2 commits into from
Dec 4, 2019

Conversation

pradeepbhadani
Copy link
Contributor

update resource name from compute_attached_disk to google_compute_attached_disk

@pradeepbhadani
update compute_attached_disk.html.markdown
665be21 
update resource name from `compute_attached_disk` to `google_compute_attached_disk`
@pradeepbhadani
update compute_attached_disk.html
84cd7b1 
fix note
@ghost ghost added the size/xs label Nov 27, 2019
@ghost ghost requested a review from megan07 November 27, 2019 13:38
@ghost ghost added the documentation label Nov 27, 2019
@ghost ghost requested a review from tysen November 27, 2019 13:39
@pradeepbhadani
Copy link
Contributor Author

pradeepbhadani commented Dec 2, 2019 •
edited
Loading

@tysen @megan07 Can you please review this PR?

@pradeepbhadani
Copy link
Contributor Author

@slevenick Can you review this PR?

@pradeepbhadani
Copy link
Contributor Author

@danawillow

megan07
megan07 approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pradeepbhadani
Copy link
Contributor Author

Thanks @megan07
@tysen Can you please review the change also?

@danawillow
Copy link
Contributor

Only one reviewer is necessary, hashibot just got excited. Removing Ty.

@danawillow danawillow removed the request for review from tysen December 4, 2019 18:45
@megan07 megan07 mentioned this pull request Dec 4, 2019
Closed
@megan07 megan07 merged commit eafb53c into hashicorp:master Dec 4, 2019
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@megan07 megan07 megan07 approved these changes

Assignees
No one assigned
Labels
documentation size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pradeepbhadani @danawillow @megan07 @paddycarver