Forwarding rule network field supports name in addition of self_link #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TF_ACC=1 go test ./google -v -run TestAccComputeForwardingRule_ -timeout 120m
=== RUN TestAccComputeForwardingRule_importBasic
--- PASS: TestAccComputeForwardingRule_importBasic (46.21s)
=== RUN TestAccComputeForwardingRule_basic
--- PASS: TestAccComputeForwardingRule_basic (45.77s)
=== RUN TestAccComputeForwardingRule_singlePort
--- PASS: TestAccComputeForwardingRule_singlePort (47.11s)
=== RUN TestAccComputeForwardingRule_ip
--- PASS: TestAccComputeForwardingRule_ip (46.00s)
=== RUN TestAccComputeForwardingRule_internalLoadBalancing
--- PASS: TestAccComputeForwardingRule_internalLoadBalancing (96.70s)
PASS |
selmanj
approved these changes
Oct 5, 2017
| resource "google_compute_forwarding_rule" "foobar" { | ||
| description = "Resource created for Terraform acceptance testing" | ||
| name = "%s" | ||
| load_balancing_scheme = "INTERNAL" | ||
| backend_service = "${google_compute_region_backend_service.foobar-bs.self_link}" | ||
| ports = ["80"] | ||
| network = "${google_compute_network.foobar.name}" |
There was a problem hiding this comment.
minor: indention should match
negz
pushed a commit
to negz/terraform-provider-google
that referenced
this pull request
Oct 17, 2017
…ashicorp#487) * Forwarding rule network field supports name in addition of self_link * Update documentation
negz
pushed a commit
to negz/terraform-provider-google
that referenced
this pull request
Oct 17, 2017
…ashicorp#487) * Forwarding rule network field supports name in addition of self_link * Update documentation
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
…ashicorp#487) * Forwarding rule network field supports name in addition of self_link * Update documentation
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
Only set remove_default_node_pool for import if false - fixes TF tests
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one resource for #431.