Remove project if it has been deleted from outside of Terraform #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
commented
Sep 26, 2017
| @@ -155,6 +155,13 @@ func resourceGoogleProjectRead(d *schema.ResourceData, meta interface{}) error { | |||
| return handleNotFoundError(err, d, fmt.Sprintf("Project %q", pid)) | |||
| } | |||
|
|
|||
| // If the project has been deleted from outside Terraform, remove it from state file. | |||
| if p.LifecycleState != "ACTIVE" { | |||
There was a problem hiding this comment.
Note:
LifecycleState has the following possible values:
- "ACTIVE"
- "DELETE_REQUESTED"
- "DELETE_IN_PROGRESS"
|
No problems here. |
selmanj
approved these changes
Sep 26, 2017
google/resource_google_project.go
Outdated
| @@ -155,6 +155,13 @@ func resourceGoogleProjectRead(d *schema.ResourceData, meta interface{}) error { | |||
| return handleNotFoundError(err, d, fmt.Sprintf("Project %q", pid)) | |||
| } | |||
|
|
|||
| // If the project has been deleted from outside Terraform, remove it from state file. | |||
| if p.LifecycleState != "ACTIVE" { | |||
| log.Printf("[WARN] Removing project '%s' because the project is not active.", pid) | |||
There was a problem hiding this comment.
Minor; printing the state as well might be useful for debugging.
negz
pushed a commit
to negz/terraform-provider-google
that referenced
this pull request
Oct 17, 2017
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
Merge 2.1.0 release into master
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #451
If everybody agree with this behavior, I will update the
google_folderresource to follow the same pattern in a separate PR.cc/ @ewbankkit