Save name-only instead of link path in pubsub_topic #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just ran into this today and was going to file a bug, but you beat me to it! Nice work! |
selmanj
approved these changes
Sep 13, 2017
negz
pushed a commit
to negz/terraform-provider-google
that referenced
this pull request
Oct 17, 2017
modular-magician
pushed a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
…nceGroupConfig (hashicorp#424) * Add support for minCpuPlatform param in InstanceGroupConfig This is a new feature in the GCloud Beta client that lets you specify the CPU architecture for all nodes in each instance group. * Add documentation for resource_dataproc_cluster min_cpu_platform * mark field as beta in docs * add beta note for both min_cpu_platforms
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #423.
Before:
------- Stdout: ------- === RUN TestAccPubsubSubscriptionCreate --- FAIL: TestAccPubsubSubscriptionCreate (5.55s) testing.go:434: Step 0 error: After applying this step and refreshing, the plan was not empty: DIFF: DESTROY/CREATE: google_pubsub_subscription.foobar_sub ack_deadline_seconds: "20" => "20" name: "pssub-test-pmz09wu8bo" => "pssub-test-pmz09wu8bo" path: "projects/*******/subscriptions/pssub-test-pmz09wu8bo" => "<computed>" topic: "pssub-test-6rnbrodpv7" => "projects/*******/topics/pssub-test-6rnbrodpv7" (forces new resource) STATE: google_pubsub_subscription.foobar_sub: ID = projects/*******/subscriptions/pssub-test-pmz09wu8bo ack_deadline_seconds = 20 name = pssub-test-pmz09wu8bo path = projects/*******/subscriptions/pssub-test-pmz09wu8bo topic = pssub-test-6rnbrodpv7 Dependencies: google_pubsub_topic.foobar_sub google_pubsub_topic.foobar_sub: ID = projects/*******/topics/pssub-test-6rnbrodpv7 name = projects/*******/topics/pssub-test-6rnbrodpv7 FAILAfter this PR: