Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oidcToken field to pubsub subscription #4215

Closed

Conversation

modular-magician
Copy link
Collaborator

Original Author: @tmshn

@dilipsubramaniam
Copy link

@slevenick Can you please review this? It looks like an important missing feature.

@DBCerigo
Copy link

DBCerigo commented Nov 6, 2019

Any chance this could be reviewed + merged, as for our usage it is indeed an important missing feature 🙏

@slevenick
Copy link
Collaborator

This was made available through a different PR. See https://www.terraform.io/docs/providers/google/r/pubsub_subscription.html for options on oidc token

@slevenick slevenick closed this Nov 6, 2019
@ghost
Copy link

ghost commented Dec 7, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 7, 2019
@modular-magician modular-magician deleted the codegen-pr-2120 branch November 16, 2024 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants