Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project import regex #4051

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Add project import regex #4051

merged 1 commit into from
Jul 17, 2019

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Jul 17, 2019 •
edited
Loading

Original Author: @slevenick

google_project add checks to import to prevent importing by project number instead of id

@ghost ghost added the size/xs label Jul 17, 2019
@modular-magician modular-magician mentioned this pull request Jul 17, 2019
Merged
@slevenick
Copy link
Collaborator

Fixes #4050

nyurik
nyurik reviewed Jul 17, 2019
View reviewed changes
Copy link
Contributor

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost added size/l documentation and removed size/xs labels Jul 17, 2019
@slevenick @modular-magician
Add project import regex
cde1fc1 
Signed-off-by: Modular Magician <[email protected]>
@ghost ghost removed the size/l label Jul 17, 2019
@slevenick slevenick merged commit 6f825f6 into hashicorp:master Jul 17, 2019
@ghost
Copy link

ghost commented Aug 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 17, 2019
@modular-magician modular-magician deleted the codegen-pr-2069 branch November 16, 2024 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nyurik nyurik nyurik left review comments

Assignees
No one assigned
Labels
documentation size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modular-magician @slevenick @nyurik