-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bigtable instance IAM resources #3939
Merged
rileykarson
merged 1 commit into
hashicorp:master
from
sandeepsukhani:bigtable-instance-iam-support
Jul 8, 2019
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| package google | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "google.golang.org/api/bigtableadmin/v2" | ||
|
|
||
| "github.com/hashicorp/errwrap" | ||
| "github.com/hashicorp/terraform/helper/schema" | ||
| "google.golang.org/api/cloudresourcemanager/v1" | ||
| ) | ||
|
|
||
| var IamBigtableInstanceSchema = map[string]*schema.Schema{ | ||
| "instance": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| }, | ||
| "project": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Computed: true, | ||
| ForceNew: true, | ||
| }, | ||
| } | ||
|
|
||
| type BigtableInstanceIamUpdater struct { | ||
| project string | ||
| instance string | ||
| Config *Config | ||
| } | ||
|
|
||
| func NewBigtableInstanceUpdater(d *schema.ResourceData, config *Config) (ResourceIamUpdater, error) { | ||
| project, err := getProject(d, config) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| d.Set("project", project) | ||
|
|
||
| return &BigtableInstanceIamUpdater{ | ||
| project: project, | ||
| instance: d.Get("instance").(string), | ||
| Config: config, | ||
| }, nil | ||
| } | ||
|
|
||
| func BigtableInstanceIdParseFunc(d *schema.ResourceData, config *Config) error { | ||
| fv, err := parseProjectFieldValue("instances", d.Id(), "project", d, config, false) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| d.Set("project", fv.Project) | ||
| d.Set("instance", fv.Name) | ||
|
|
||
| // Explicitly set the id so imported resources have the same ID format as non-imported ones. | ||
| d.SetId(fv.RelativeLink()) | ||
| return nil | ||
| } | ||
|
|
||
| func (u *BigtableInstanceIamUpdater) GetResourceIamPolicy() (*cloudresourcemanager.Policy, error) { | ||
| req := &bigtableadmin.GetIamPolicyRequest{} | ||
| p, err := u.Config.clientBigtableProjectsInstances.GetIamPolicy(u.GetResourceId(), req).Do() | ||
| if err != nil { | ||
| return nil, errwrap.Wrapf(fmt.Sprintf("Error retrieving IAM policy for %s: {{err}}", u.DescribeResource()), err) | ||
| } | ||
|
|
||
| cloudResourcePolicy, err := bigtableToResourceManagerPolicy(p) | ||
| if err != nil { | ||
| return nil, errwrap.Wrapf(fmt.Sprintf("Invalid IAM policy for %s: {{err}}", u.DescribeResource()), err) | ||
| } | ||
|
|
||
| return cloudResourcePolicy, nil | ||
| } | ||
|
|
||
| func (u *BigtableInstanceIamUpdater) SetResourceIamPolicy(policy *cloudresourcemanager.Policy) error { | ||
| bigtablePolicy, err := resourceManagerToBigtablePolicy(policy) | ||
| if err != nil { | ||
| return errwrap.Wrapf(fmt.Sprintf("Invalid IAM policy for %s: {{err}}", u.DescribeResource()), err) | ||
| } | ||
|
|
||
| req := &bigtableadmin.SetIamPolicyRequest{Policy: bigtablePolicy} | ||
| _, err = u.Config.clientBigtableProjectsInstances.SetIamPolicy(u.GetResourceId(), req).Do() | ||
| if err != nil { | ||
| return errwrap.Wrapf(fmt.Sprintf("Error setting IAM policy for %s: {{err}}", u.DescribeResource()), err) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (u *BigtableInstanceIamUpdater) GetResourceId() string { | ||
| return fmt.Sprintf("projects/%s/instances/%s", u.project, u.instance) | ||
| } | ||
|
|
||
| func (u *BigtableInstanceIamUpdater) GetMutexKey() string { | ||
| return fmt.Sprintf("iam-bigtable-instance-%s-%s", u.project, u.instance) | ||
| } | ||
|
|
||
| func (u *BigtableInstanceIamUpdater) DescribeResource() string { | ||
| return fmt.Sprintf("Bigtable Instance %s/%s", u.project, u.instance) | ||
| } | ||
|
|
||
| func resourceManagerToBigtablePolicy(p *cloudresourcemanager.Policy) (*bigtableadmin.Policy, error) { | ||
| out := &bigtableadmin.Policy{} | ||
| err := Convert(p, out) | ||
| if err != nil { | ||
| return nil, errwrap.Wrapf("Cannot convert a bigtable policy to a cloudresourcemanager policy: {{err}}", err) | ||
| } | ||
| return out, nil | ||
| } | ||
|
|
||
| func bigtableToResourceManagerPolicy(p *bigtableadmin.Policy) (*cloudresourcemanager.Policy, error) { | ||
| out := &cloudresourcemanager.Policy{} | ||
| err := Convert(p, out) | ||
| if err != nil { | ||
| return nil, errwrap.Wrapf("Cannot convert a cloudresourcemanager policy to a bigtable policy: {{err}}", err) | ||
| } | ||
| return out, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding a logging message similar to other clients? This is mostly for consistency, it can also help with debugging if the value isn't being set.