Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where flattened ip_address had extra empty element #357

Merged
merged 1 commit into from
Aug 25, 2017

Conversation

selmanj
Copy link
Contributor

@selmanj selmanj commented Aug 24, 2017

The combination of append and preallocation of the ips caused a single
empty element at the beginning of the list.

Fixes #352

The combination of append and preallocation of the ips caused a single
empty element at the beginning of the list.
@selmanj selmanj requested a review from paddycarver August 24, 2017 23:15
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch! Tests pass, merge at will.

@selmanj selmanj merged commit b29337d into hashicorp:master Aug 25, 2017
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
…#357)

The combination of append and preallocation of the ips caused extra
empty elements at the beginning of the list.
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
<!-- This change is generated by MagicModules. -->
/cc @chrisst
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud SQL does not expose IP through address 0
2 participants