Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace hazardous tf patterns in docs #3403

Merged
merged 2 commits into from
May 7, 2019

Conversation

rsalmond
Copy link
Contributor

@rsalmond rsalmond commented Apr 9, 2019

Hard coding a name on a sql instance is ill advised for reasons outlined a little ways down in the docs.

For folks who just read the example code and tailor it to meet their needs we should present a better pattern from the outset.

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the improvement, thanks @rsalmond!

@ghost
Copy link

ghost commented Jun 7, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants