Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the limit on # of master authorized networks in GKE #3397

Merged
merged 1 commit into from
Apr 8, 2019
+3 −3
Merged

Relax the limit on # of master authorized networks in GKE #3397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion google/resource_container_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ var (
Type: schema.TypeSet,
Optional: true,
Computed: true,
MaxItems: 20,
Elem: cidrBlockConfig,
},
},
Expand Down
1 change: 1 addition & 0 deletions google/resource_sql_database_instance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"github.com/hashicorp/terraform/helper/acctest"
"github.com/hashicorp/terraform/helper/resource"
"github.com/hashicorp/terraform/terraform"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that this got added

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a concurrency thing, that goimports behaviour changes based on the ordering of generated files.

sqladmin "google.golang.org/api/sqladmin/v1beta4"
)

Expand Down
4 changes: 2 additions & 2 deletions website/docs/r/container_cluster.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,8 @@ This block also contains several computed attributes, documented below. If this

The `master_authorized_networks_config` block supports:

* `cidr_blocks` - (Optional) Defines up to 20 external networks that can access
Kubernetes master through HTTPS.
* `cidr_blocks` - (Optional) External networks that can access the
Kubernetes cluster master through HTTPS.

The `master_authorized_networks_config.cidr_blocks` block supports:

Expand Down