Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform: Make private Cloud DNS GA #3352

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

modular-magician
Copy link
Collaborator

/cc @drebes

@gburiola
Copy link

Hey @rileykarson

when I upgraded from 2.3.0 to 2.4.0 I noticed that terraform tries to recreate all my google_dns_managed_zone.

-/+ google_dns_managed_zone.myzone-com (new resource required)
      id:             "myzone-com" => <computed> (forces new resource)
      description:    "DNS zone for myzone.com" => "DNS zone for myzone.com"
      dns_name:       "myzone.com." => "myzone.com."
      name:           "myzone-com" => "myzone-com"
      name_servers.#: "4" => <computed>
      project:        "my-project" => <computed>
      visibility:     "" => "public" (forces new resource)

That's because the new visibility field changes from empty to public.

The final resource would still be created correctly, but destroying and recreating managed DNS zones could have a big impact on prod projects.

Is there any chance we could make this change backwards compatible and avoid the resource recreation?

@gburiola
Copy link

I just noticed there's already an issue related to this:
#3435

@ghost
Copy link

ghost commented May 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 2, 2019
@modular-magician modular-magician deleted the codegen-pr-1600 branch November 17, 2024 00:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants