Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect arguments for google_compute_instance data source #2874

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

lawliet89
Copy link
Contributor

Fixes #2535

I ran the test with:

GOOGLE_REGION="us-central1" GOOGLE_ZONE="us-central1-a" \
GOOGLE_PROJECT="xxx" GOOGLE_CREDENTIALS=xxx.json \
make testacc TEST=./google TESTARGS='-run=TestAccDataSourceComputeInstance_basic'

and the test passes:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccDataSourceComputeInstance_basic -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceComputeInstance_basic
=== PAUSE TestAccDataSourceComputeInstance_basic
=== CONT  TestAccDataSourceComputeInstance_basic
--- PASS: TestAccDataSourceComputeInstance_basic (157.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	157.813s

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I lost track of the issue. This will be merged once GoogleCloudPlatform/magic-modules#1249 is approved.

modular-magician pushed a commit to modular-magician/terraform-provider-google that referenced this pull request Jan 15, 2019
@rileykarson rileykarson merged commit 51bf081 into hashicorp:master Jan 15, 2019
@lawliet89 lawliet89 deleted the fix-instance-data branch January 16, 2019 01:24
@ghost
Copy link

ghost commented Feb 15, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants