-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataproc encryption params added #2772
Conversation
Folks what's the ETA to get this merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Can you add the new fields to the documentation for dataproc cluster ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, meant to click the other button.
Hi @chrisst , |
Hey, sorry for the delay. Usually I ask for integration tests to be updated so that the new feature is tested but the new KMS features aren't very easily tested and require a lot of boiler plate to get a single test to run. I'm working on a feature that should make it a lot easier to test KMS integration with new resources that I should have up shortly. Whether my new test strategy works or not I'll make sure this gets in for our next release. |
Do you need any help with that? |
Possible test implementation: #2824 |
This was added upstream and the generated pr was merged in #2840 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
No description provided.