Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataproc encryption params added #2772

Closed
wants to merge 3 commits into from

Conversation

vktr-brlv
Copy link

No description provided.

@ghost ghost added the size/s label Dec 30, 2018
@vktr-brlv vktr-brlv closed this Dec 30, 2018
@vktr-brlv vktr-brlv reopened this Dec 30, 2018
@anton-opsguru
Copy link

Folks what's the ETA to get this merged ?

Copy link
Contributor

@chrisst chrisst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Can you add the new fields to the documentation for dataproc cluster ?

google/resource_dataproc_cluster.go Outdated Show resolved Hide resolved
google/resource_dataproc_cluster.go Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisst chrisst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, meant to click the other button.

@chrisst chrisst self-assigned this Jan 2, 2019
@ghost ghost added the documentation label Jan 3, 2019
@vktr-brlv
Copy link
Author

Hi @chrisst ,
Are we still missing something?

@chrisst
Copy link
Contributor

chrisst commented Jan 7, 2019

Hey, sorry for the delay. Usually I ask for integration tests to be updated so that the new feature is tested but the new KMS features aren't very easily tested and require a lot of boiler plate to get a single test to run. I'm working on a feature that should make it a lot easier to test KMS integration with new resources that I should have up shortly.

Whether my new test strategy works or not I'll make sure this gets in for our next release.

@vktr-brlv
Copy link
Author

Do you need any help with that?
We can share working terraform examples with new params if you need.

@chrisst chrisst mentioned this pull request Jan 7, 2019
@chrisst
Copy link
Contributor

chrisst commented Jan 8, 2019

Possible test implementation: #2824

@chrisst
Copy link
Contributor

chrisst commented Jan 22, 2019

This was added upstream and the generated pr was merged in #2840

@chrisst chrisst closed this Jan 22, 2019
@ghost
Copy link

ghost commented Feb 22, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants