Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Go modules. #2679

Merged
merged 6 commits into from
Dec 20, 2018
Merged

Switch to using Go modules. #2679

merged 6 commits into from
Dec 20, 2018

Conversation

paddycarver
Copy link
Contributor

This migrates our vendor.json to use Go 1.11's modules system, and
replaces the vendor folder with the output of go mod vendor.

The vendored code should remain basically the same; I believe some
tree shaking of packages and support scripts/licenses/READMEs/etc.
happened.

This also fixes Travis and our Makefile to no longer use govendor.

(This is a replacement for #2666, except based on @ndmckinley's
work to get 2.0.0 stuff on master.)

@nat-henderson
Copy link
Contributor

Delightful. :) Thank you!

paddycarver and others added 5 commits December 18, 2018 15:38
This migrates our vendor.json to use Go 1.11's modules system, and
replaces the vendor folder with the output of go mod vendor.

The vendored code should remain basically the same; I believe some
tree shaking of packages and support scripts/licenses/READMEs/etc.
happened.

This also fixes Travis and our Makefile to no longer use govendor.
This migrates our vendor.json to use Go 1.11's modules system, and
replaces the vendor folder with the output of go mod vendor.

The vendored code should remain basically the same; I believe some
tree shaking of packages and support scripts/licenses/READMEs/etc.
happened.

This also fixes Travis and our Makefile to no longer use govendor.

(This is a replacement for #2666, except based on @ndmckinley's
work to get 2.0.0 stuff on master.)
Somehow 1.20 got duplicated.
@nat-henderson nat-henderson self-requested a review December 20, 2018 21:38
@paddycarver
Copy link
Contributor Author

To keep this here as well:

How this happened:

  1. go mod init github.com/terraform-providers/terraform-provider-google-beta - initialize go modules, convert our old vendor.json.
  2. go mod tidy - clean up the dependencies and find indirect dependencies.
  3. go get github.com/hashicorp/terraform/helper/schema@35d82b055591e9d47a254e68754216d8849ba67a to vendor the version of helper/schema we need.
  4. go mod tidy to clean up the vendoring again.
  5. rm -r vendor/ to get rid of the old vendored code
  6. go mod vendor to vendor based on Go modules
  7. manually delete some lines and change some others in the Makefile

To vendor new things or update existing vendors once this is merged:

  1. go get $url@$commit_sha_2_vendor ($commit_sha_2_vendor could also be a version, if the package is a module and support versions, and the commit we need is in a published version)
  2. go mod tidy
  3. go mod vendor
  4. commit and PR

@paddycarver paddycarver merged commit 2ac95fb into nmckinley-new-master Dec 20, 2018
@paddycarver paddycarver deleted the paddy_go_mod branch December 20, 2018 21:44
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
Switch to using Go modules.

This migrates our vendor.json to use Go 1.11's modules system, and
replaces the vendor folder with the output of go mod vendor.

The vendored code should remain basically the same; I believe some
tree shaking of packages and support scripts/licenses/READMEs/etc.
happened.

This also fixes Travis and our Makefile to no longer use govendor.
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
Switch to using Go modules.

This migrates our vendor.json to use Go 1.11's modules system, and
replaces the vendor folder with the output of go mod vendor.

The vendored code should remain basically the same; I believe some
tree shaking of packages and support scripts/licenses/READMEs/etc.
happened.

This also fixes Travis and our Makefile to no longer use govendor.
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
Switch to using Go modules.

This migrates our vendor.json to use Go 1.11's modules system, and
replaces the vendor folder with the output of go mod vendor.

The vendored code should remain basically the same; I believe some
tree shaking of packages and support scripts/licenses/READMEs/etc.
happened.

This also fixes Travis and our Makefile to no longer use govendor.
@ghost
Copy link

ghost commented Jan 20, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants