support firestore cloud function triggers #2480
Conversation
There was a problem hiding this comment.
Thanks @matthewrj! I've got a few questions/comments that are mostly to clarify my assumptions about Firestore.
Do you mind updating the documentation as well to state that we support this new trigger type? https://github.com/terraform-providers/terraform-provider-google/blob/2.0.0/website/docs/r/cloudfunctions_function.html.markdown
|
@rileykarson I've addressed all the points you raised. |
There was a problem hiding this comment.
LGTM! Thanks for your contribution. I'll upstream this to Magic Modules and merge alongside the Beta provider downstream.
* support firestore cloud function triggers * document firestore trigger specifics
* support firestore cloud function triggers * document firestore trigger specifics
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This PR adds support for firestore event triggers for cloud functions.
The docs for firestore events can be found here: https://cloud.google.com/functions/docs/calling/cloud-firestore