-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for requester_pays to google_storage_bucket #2402
Conversation
Travis seems to have failed for a gofmt on a file I didnt touch and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - Could you go ahead and add the documentation for this switch? The build issues are likely on our end - I'll investigate.
Documentation added. Thanks! |
GitHub seems to have been wildly confused about that first commit - my theory is that your commit had the |
@ndmckinley Thanks for approving -- is there a rough idea of when 2.0.0 will be released (or what else needs to happen to complete it) ? |
@ndmckinley have you moved this into MM? |
I haven't - I'll make sure to do that, and that it gets into the 1.20 release branch. |
Looks like this was resolved with #2580? It didn't make it in to |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This is a fix for issue #2332. As you can see, I've built this on top of the 2.0.0 branch, but was unsure if it's more appropriate to use master or something else -- I'm happy to move it and feedback on the changes most welcome, so please let me know.
Thanks