Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for requester_pays to google_storage_bucket #2402

Closed

Conversation

lawrenae
Copy link
Contributor

@lawrenae lawrenae commented Nov 5, 2018

This is a fix for issue #2332. As you can see, I've built this on top of the 2.0.0 branch, but was unsure if it's more appropriate to use master or something else -- I'm happy to move it and feedback on the changes most welcome, so please let me know.

Thanks

@ghost ghost added the size/xxl label Nov 5, 2018
@lawrenae lawrenae changed the base branch from master to 2.0.0 November 5, 2018 14:03
@lawrenae
Copy link
Contributor Author

lawrenae commented Nov 5, 2018

Travis seems to have failed for a gofmt on a file I didnt touch and make website-test has broken links. is this something I can/should fix?

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Could you go ahead and add the documentation for this switch? The build issues are likely on our end - I'll investigate.

@lawrenae
Copy link
Contributor Author

lawrenae commented Nov 12, 2018

Documentation added.

Thanks!

@ghost ghost added size/m and removed size/xxl labels Nov 12, 2018
@nat-henderson
Copy link
Contributor

GitHub seems to have been wildly confused about that first commit - my theory is that your commit had the master base branch at first and that confused it. Your new commit seems right. :)

@lawrenae
Copy link
Contributor Author

@ndmckinley Thanks for approving -- is there a rough idea of when 2.0.0 will be released (or what else needs to happen to complete it) ?

@danawillow
Copy link
Contributor

@ndmckinley have you moved this into MM?

@nat-henderson
Copy link
Contributor

I haven't - I'll make sure to do that, and that it gets into the 1.20 release branch.

@rileykarson
Copy link
Collaborator

Looks like this was resolved with #2580?

It didn't make it in to 1.20.0 - this should release as part of 2.0.0.

@ghost
Copy link

ghost commented Jan 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants